Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release / v1.6.0 #380

Merged
merged 38 commits into from
Apr 8, 2024
Merged

Release / v1.6.0 #380

merged 38 commits into from
Apr 8, 2024

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Apr 5, 2024

Description

Bet Bonus functionality has been added to the reward module, bet bonus will be granted to chosen users for bets which are winner or loser. The grant process needs a manual transaction broadcast with the bet UID included in the ticket.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Promoter Transactions and Queries
  • Bet bonus campaign definition and configurations
  • Bet bonus reward grant according to the campaign configurations

Test Cases

  • Complete coverage of bet bonus logic
  • Include promoter support to the test cases

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

scorpioborn and others added 30 commits February 27, 2024 13:17
the commit. # # On branch feature/reward-bet-bonus # Changes to be committed: # modified:  proto/sge/reward/ticket.proto #
new file:  x/reward/types/reward_bet_bonus.go # modified:  x/reward/types/ticket.pb.go #
…ount

Feature / Campaign custom withdraw amount
@scorpioborn scorpioborn marked this pull request as ready for review April 7, 2024 12:18
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners April 7, 2024 12:18
@3eyedraga 3eyedraga merged commit 3ee84c9 into master Apr 8, 2024
22 checks passed
@3eyedraga 3eyedraga deleted the release/v1.6.x branch April 8, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants