Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subaccount module part4 #219

Merged
merged 6 commits into from
Jul 23, 2023
Merged

Subaccount module part4 #219

merged 6 commits into from
Jul 23, 2023

Conversation

faultytolly
Copy link
Contributor

Description

Type of change

Please check the options that are relevant. This PR introduces

  • Bug fix (non-breaking change which fixes an existing issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation

Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@faultytolly faultytolly marked this pull request as ready for review July 17, 2023 08:35
@3eyedraga
Copy link
Contributor

@faultytolly please resolve conflicts

@3eyedraga 3eyedraga self-requested a review July 21, 2023 02:33
@3eyedraga 3eyedraga merged commit d876f42 into sge-network:feature/subaccount Jul 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3eyedraga 3eyedraga Awaiting requested review from 3eyedraga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faultytolly @3eyedraga