-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of system-wide proxys #49
Open
niclasm17
wants to merge
1
commit into
sfudeus:master
Choose a base branch
from
niclasm17:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
#!/usr/bin/env python3 | ||
|
||
import xmlrpc.client | ||
import argparse | ||
import logging | ||
|
@@ -8,19 +7,43 @@ | |
import json | ||
import re | ||
import sys | ||
import os | ||
|
||
from socketserver import ThreadingMixIn | ||
from http.server import HTTPServer | ||
from pprint import pformat | ||
import requests | ||
from prometheus_client import Gauge, Counter, Enum, MetricsHandler, core, Summary, start_http_server | ||
|
||
from urllib.parse import urlparse | ||
|
||
## Allow homematic_exporter to use the system-wide configured http(s) proxy | ||
class ProxiedTransport(xmlrpc.client.Transport): | ||
def __init__(self): | ||
proxy_http = os.environ.get('http_proxy') | ||
proxy_https = os.environ.get('https_proxy') | ||
proxy = proxy_https if proxy_https else proxy_http | ||
proxy_parts = urlparse(proxy) | ||
self.proxy = proxy_parts.hostname | ||
self.proxy_port = proxy_parts.port | ||
self.proxy_headers = {} | ||
super().__init__(self) | ||
|
||
def make_connection(self, host): | ||
if not self.proxy or host.startswith('https'): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. even https could be proxied (through the https_proxy) |
||
return super().make_connection(host) | ||
self.realhost = host | ||
import http.client | ||
h = http.client.HTTPConnection(self.proxy, self.proxy_port) | ||
h.set_tunnel(self.realhost, headers=self.proxy_headers) | ||
return h | ||
|
||
class HomematicMetricsProcessor(threading.Thread): | ||
|
||
METRICS_NAMESPACE = 'homematic' | ||
# Supported Homematic (BidcosRF and IP) device types | ||
DEFAULT_SUPPORTED_TYPES = [ | ||
'HmIP-eTRV-2 I9F', | ||
'HmIP-eTRV-B', | ||
'HmIP-eTRV-2', | ||
'HmIP-eTRV-C', | ||
'HmIP-eTRV-C-2', | ||
|
@@ -244,7 +267,7 @@ def generate_metrics(self): | |
logging.debug(pformat(paramset)) | ||
|
||
def create_proxy(self): | ||
transport = xmlrpc.client.Transport() | ||
transport = ProxiedTransport() | ||
connection = transport.make_connection(self.ccu_host) | ||
connection.timeout = 5 | ||
return xmlrpc.client.ServerProxy(self.ccu_url, transport=transport) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback is mostly intended, but not helpful when only one scheme needs a proxy and the other doesn't. And the main decision should be taken on the originally requested scheme.