Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update connectorx-python: avoid diving into the exception for recent … #719

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions connectorx-python/connectorx/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,10 @@ def read_sql(
if return_type in {"polars", "polars2"}:
pl = try_import_module("polars")
try:
df = pl.DataFrame.from_arrow(df)
except AttributeError:
# api change for polars >= 0.8.*
df = pl.from_arrow(df)
except AttributeError:
# previous polars api (< 0.8.*) was pl.DataFrame.from_arrow
df = pl.DataFrame.from_arrow(df)
else:
raise ValueError(return_type)

Expand Down
Loading