Adds RowDescription to the SimpleQueryMessage #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Jul 7, 2024
tokio-postgres/src/simple_query.rs
Outdated
| _ => return Poll::Ready(Some(Err(Error::unexpected_message()))), | ||
| *this.columns = Some(columns.clone()); | ||
| Poll::Ready(Some(Ok(SimpleQueryMessage::RowDescription( | ||
| columns.clone(), |
There was a problem hiding this comment.
You shouldn't need to clone here.
There was a problem hiding this comment.
I was originally confused about this, but thought it over and figured out a solution. I've added a change to reduce it to just 1 clone instead of 2.
sfackler
reviewed
Jul 8, 2024
tokio-postgres/src/simple_query.rs
Outdated
Comment on lines
104
to
107
| *this.columns = Some(columns); | ||
| Poll::Ready(Some(Ok(SimpleQueryMessage::RowDescription( | ||
| columns.clone(), | ||
| this.columns.as_ref().unwrap().clone(), | ||
| )))) |
There was a problem hiding this comment.
Wouldn't this work?
*this.columns = Some(columns.clone());
Poll::Ready(Some(Ok(SimpleQueryMessage::RowDescription(
columns
))))There was a problem hiding this comment.
Yes, it does. I was clearly overthinking it. Thank you!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RowDescription to the SimpleQueryMessage to allow column information to be consumed without needing to consume any DataRows
Resolves #1143