Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rustc-serialize dependency #1074

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

ds-cbo
Copy link
Contributor

@ds-cbo ds-cbo commented Oct 20, 2023

Fixes #1073


Sadly I wasn't able to run all tests locally because I got the following error while running them:

Error { kind: Tls, cause: Some(Error { code: -67843, message: "The certificate was not trusted." }) }

I am guessing this has something to do with macOS and Docker, but it's out of scope for me to debug that.

@ds-cbo
Copy link
Contributor Author

ds-cbo commented Nov 2, 2023

Now that the clippy warnings have been fixed by the other PR, could you please retrigger CI for this one?

@sfackler
Copy link
Owner

sfackler commented Nov 2, 2023

You'll need to rebase/merge the master branch back into this branch.

@sfackler sfackler merged commit cc93651 into sfackler:master Nov 3, 2023
4 checks passed
@ds-cbo ds-cbo deleted the remove-rustc-serialize-dependency branch November 6, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dev-)dependency eui48 is abandoned and will stop compiling
2 participants