OpenXR: Add interaction profiles for hand tracking #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Adams <[email protected]>
|
Marking as draft as this is still a bit rough, but in its current state is at least functional |
Signed-off-by: Daniel Adams <[email protected]>
msub2
force-pushed
the
hand-interaction-profiles
branch
from
a37a559
to
19d5b5a
Compare
Signed-off-by: Daniel Adams <[email protected]>
jdm
approved these changes
Aug 11, 2024
webxr/openxr/input.rs
Outdated
Comment on lines
568
to
569
| let hand = self.hand_tracker.as_ref().and_then(|tracker| { | ||
| Some(locate_hand( |
There was a problem hiding this comment.
and_then + Some is the same is equivalent to map, right?
There was a problem hiding this comment.
There's a subtle difference (after removing unneeded ? and Some()), using map+locate_hand returns an Option<Option<Box<Hand<JointFrame>>>>, using and_then+locate_hand flattens it to just Option<Box<Hand<JointFrame>>>
Signed-off-by: Daniel Adams <[email protected]>
Signed-off-by: Daniel Adams <[email protected]>
Signed-off-by: Daniel Adams <[email protected]>
Signed-off-by: Daniel Adams <[email protected]>
Signed-off-by: Daniel Adams <[email protected]>
jdm
approved these changes
Aug 12, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the handling for hand tracking in OpenXR to be able to better get both aim pose and select status from hand trackers, as previously it was relying on hardcoded actions that don't exist in every runtime. This should supersede #151 as well