Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved graph rendering in the Dashboard #473

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Misc. graph improvements:

  • Task names are now in bold
  • Enlarged arrow marker size
  • Reduced the height of the clusters header
  • Reduced the space between ranks
  • Adjusted node Y when rendering, provides a better "centering" inside a cluster
  • Fixed try/catch code selection when clicking on their node

image

- Task names are now in bold
- Enlarged arrow marker size
- Reduced the height of the clusters header
- Reduced the space between ranks
- Adjusted node Y when rendering, provides a better "centering" inside a cluster

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi added type: enhancement New feature or request app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue weight: 1 An issue that has a very low development impact labels Dec 19, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Dec 19, 2024
@JBBianchi JBBianchi requested a review from cdavernas December 19, 2024 15:24
@JBBianchi JBBianchi self-assigned this Dec 19, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers bro ❤️

@cdavernas cdavernas merged commit 978ecd0 into main Dec 19, 2024
2 checks passed
@cdavernas cdavernas deleted the fix-dashboard-graph-improvements branch December 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: enhancement New feature or request weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants