Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-alpha1 #847

Merged
merged 10 commits into from
May 22, 2024
Merged

1.0.0-alpha1 #847

merged 10 commits into from
May 22, 2024

Conversation

cdavernas
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:
#843

What this PR does / why we need it:

The version 1.0.0-alpha1 is one of the most impacting release of the history of the Serverless Workflow DSL. It aims at both drastically simplify the DSL and at completing it with many new features.

It is intended to be the last release containing breaking changes before the Serverless Workflow DSL 1.0.0 can see the day.

What's new?

Includes fixes to comments by @ricardozanini

Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas cdavernas requested review from fjtirado and JBBianchi and removed request for tsurdilo and antmendoza May 21, 2024 11:15
@cdavernas
Copy link
Member Author

This is a rebase of previous PR, which had gone critically wrong with signoffs.

@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. area: ctk Changes in the CTK (Compliance Test Kit) area: cicd Changes in the CI/CD labels May 21, 2024
@cdavernas cdavernas added this to the v1.0.0-alpha1 milestone May 21, 2024
Signed-off-by: Charles d'Avernas <[email protected]>
dsl.md Outdated Show resolved Hide resolved
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move on and handle the minors in another PR.

@cdavernas do you agree that we need to convert the examples into the new DSL and keep them here?

If so, we can open a new issue and do so.

@cdavernas
Copy link
Member Author

@ricardozanini Not necessarilly, as they are given by the features. Those might be difficult to find for newcomers, though, intimidated by ctk, features, ...

But if you feel we should, then I'll get going before merging this one.

@ricardozanini
Copy link
Member

@cdavernas I can send a PR on top of yours to fix the examples if you want, but tomorrow. Today my day is packed already :D

cdavernas added 3 commits May 22, 2024 14:40
- Updated/fixed the dsl-reference.md file
- Ordered maintainers and code owners by alphabetic order
- Deleted the obsolete specification.md file

Signed-off-by: Charles d'Avernas <[email protected]>
…untime expression language and mode.

Partially addresses serverlessworkflow#848

Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas
Copy link
Member Author

@ricardozanini I added the first example, to boostrap the PR you spoke about.

In the mean time, should I merge?

@ricardozanini
Copy link
Member

@cdavernas sure, let's merge if you have the fup issues to handle the pending tasks we have. 👍

dsl.md Outdated Show resolved Hide resolved
@cdavernas
Copy link
Member Author

Created #850, #851 and #852 which are the main requirements, aside from all optimizations, corrections, fixes, etc.

@cdavernas cdavernas merged commit 2d79abe into serverlessworkflow:main May 22, 2024
2 of 4 checks passed
@cdavernas cdavernas deleted the 1.0.0-alpha1 branch May 22, 2024 15:15
@cdavernas
Copy link
Member Author

cdavernas commented May 22, 2024

Closes #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cicd Changes in the CI/CD area: ctk Changes in the CTK (Compliance Test Kit) area: spec Changes in the Specification change: breaking A breaking change that will impact in a major version change. change: documentation Improvements or additions to documentation. It won't impact a version change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants