Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emeritus Maintaner role; Add 2 days period for merging PRs #841

Merged
merged 5 commits into from
May 17, 2024

Conversation

ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:

Discussion took place between the Serverless WG Maintainers.

What this PR does / why we need it:

In this PR, we update our governance model to include a new Emeritus Maintainer role to praise maintainers who wish to move forward as advisors without the obligations of active maintainers.

Additionally, we rephrased the Lazy Consensus rule to highlight that after a PR gets approved by another maintainer, others have 2 days notice before it gets merged.

Special notes for reviewers:

Additional information:

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@duglin duglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM
Just a few minor wording suggestions - even if not made, I'm ok with it.

ricardozanini and others added 2 commits May 15, 2024 14:53
@ricardozanini
Copy link
Member Author

@duglin I've incorporated your comments. Mind doing a quick look?

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks @ricardozanini !

@cdavernas cdavernas merged commit ca10bc3 into serverlessworkflow:main May 17, 2024
2 checks passed
@ricardozanini ricardozanini deleted the govmodel-2d branch May 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants