Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streaming capabilities to both the listen task and to the asyncapi (subscribe operation) call #1070

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Add streaming capabilities to both the listen task and to the asyncapi (subscribe operation) call #1070

merged 4 commits into from
Jan 15, 2025

Conversation

cdavernas
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
#1068
#1069

What this PR does:

  • Adds a new foreach property to both listen task and asyncapi call, used to configure the iterator used to process consumed events/messages
  • Adds a new read property to the listen task, used to configure how to read consumed events

@cdavernas
- Add a new foreach property to both listen task and asyncapi c…
d274143 
…all, used to configure the iterator used to process consumed events/messages

- Add a new `read` property to the `listen` task, used to configure how to read consumed events

Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification area: examples labels Jan 15, 2025
@cdavernas cdavernas added this to the v1.0.0 milestone Jan 15, 2025
@cdavernas cdavernas self-assigned this Jan 15, 2025
@cdavernas
Fix samples
6b6a8fe 
Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas cdavernas changed the title Add streaming features to both the listen task and to the asyncapi (subscribe operation) call Add streaming capabilities to both the listen task and to the asyncapi (subscribe operation) call Jan 15, 2025
This was linked to issues Jan 15, 2025
Add proper streaming consumption support and document output of AsyncAPI subscribe operations #1069
Closed
Add a new property to the listen task to determine what it should return #1068
Closed
@fjtirado fjtirado self-requested a review January 15, 2025 11:54
fjtirado
fjtirado approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack, maybe adding a note to until to indicate that events received on until should not be output collected
Great work!!!

@cdavernas
Add a warning explaining that events consumed by an until clause sh…
21e0ece 
…ould be excluded by a `listen` task's output, following @fjtirado's comment

Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas cdavernas merged commit be474b2 into serverlessworkflow:main Jan 15, 2025
3 checks passed
@cdavernas cdavernas deleted the feat-act-upon-streaming branch January 15, 2025 15:44
This was referenced Jan 16, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjtirado fjtirado fjtirado approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees

@cdavernas cdavernas

Labels
area: examples area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0
3 participants
@cdavernas @ricardozanini @fjtirado