-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud events to be publlished when workflow status change #1030
Comments
The first thing (my guess) that we should decide is between:
It is easier to consume different event types by another workflow (you just put the type on the event task) while using attributes requires filtering of those attributes (if they are cloud event attributes, there wont be need to deserialize the data to perform the filter, at least theoretically) Regardless the decision on that question, my bet is that, besides the status itself, we should include the workflow name plus the current input and context (if context is large, the event will be potentially huge, I guess that we can let implementors to leave that configurable) |
I'd definitly go for your first suggestion, which makes routing/processing easier and more compliant with the Cloud Event Spec: the payload of the events should be opaque to those concerns. If required, though, we could also add a Workflow/Task Status Changed event, used by "lazy" consumers to reflect status changes (it would be a kind of duplicate of other events, but with a simplistic payload limited to As for the events types, I'd recommend using the following:
|
@cdavernas Ill open PR to incorporate your proposal to the spec, thanks a lot!!! |
@fjtirado Are you still on it? Otherwise I can do it if you prefer ;) |
@cdavernas Hi, please go ahead, thanks a lot! |
Closes serverlessworkflow#1030 Signed-off-by: Charles d'Avernas <[email protected]>
Possible workflow status are defined in the specifcation. However, there is not information of the content of the cloud event that very likely any implementation might publish when status is changed.
What would you like to be added:
Common content of the cloud events to be published when a status is changed
Why is this needed:
To make it possible users of any implementation to rely on the common content when listening to a status phase change event.
The text was updated successfully, but these errors were encountered: