Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Switch task implementation #466

Closed
Tracked by #459
fjtirado opened this issue Nov 13, 2024 · 3 comments · Fixed by #472
Closed
Tracked by #459

Add Switch task implementation #466

fjtirado opened this issue Nov 13, 2024 · 3 comments · Fixed by #472
Assignees

Comments

@fjtirado
Copy link
Collaborator

fjtirado commented Nov 13, 2024

Implements https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#switch

@fjtirado fjtirado self-assigned this Nov 13, 2024
@mcruzdev
Copy link

Hi @fjtirado could you assign it o me?

@fjtirado
Copy link
Collaborator Author

fjtirado commented Nov 22, 2024

@mcruzdev Im already working on it. Its a pretty complex one affecting the whole structure of the implementation.
Maybe, if you are willing to contribute to the spec, you can work on serverlessworkflow/specification#1030, wdyt?

In fact, the reason I have not uploaded the PR yet is that there is an ongoing discussion on CNCF about the possible values of task names on then: which heavily impacts the implementation.

@fjtirado
Copy link
Collaborator Author

fjtirado commented Nov 22, 2024

@mcruzdev Knowing that you want to work on the reference implementation, once I have completed this one and error handlng (both affects the current TaskExecutor interface) I would open more issues and discuss which ones can you help me with. Im thinking on authorization support for http calls and openapi task, but, in order to avoid collisions, I have to finish this one first.

fjtirado added a commit to fjtirado/sdk-java that referenced this issue Nov 22, 2024
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Nov 22, 2024
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Nov 25, 2024
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Nov 25, 2024
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Nov 25, 2024
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Nov 25, 2024
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit that referenced this issue Nov 25, 2024
[Fix #466]  Implement switch, set and do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants