-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: distinct entryPoint and function name #97
base: master
Are you sure you want to change the base?
Conversation
@pmuens you can see this PR plz ? Thank a lot |
I was about to open the same PR, thanks @CaptainJojo! Question: Is it possible to add the
|
Based on your PR, I've ended up writing my own one (PR #98) , because I found that yours was changing the logic a lot, which is breaking changes to anybody already using that plugin. Cheers! |
Yes thank, I prefer your PR they are no breaking change :) |
@CaptainJojo fun fact, i think your PR was a must as well hehe, but should be optional by passing an option in the |
@markmssd ok I check that :) |
Thanks :D |
You think is mandatory use service ? Just stage is enought ? |
In my opinion I think it is, so there is no conflicts in naming when 2 functions have the same name. We can compare with the AWS plugin to see if it also adds the service name etc. |
ok It's finish with |
Awesome thanks!! @pmuens any thoughts on that? |
@pmuens ? |
FYI, I proceeded to fork this project (https://github.com/digital-dynamite/serverless-google-cloudfunctions-awesome) (npm link) and have it include all our changes. So what I have more:
Thanks again @CaptainJojo ! |
This PR differentiates the name of the function with the name of the entry point.
This allows the stage to be used correctly. This will create for the same code, a function per stage.
I change in:
entryPoint
and nameTest
With this config
I can deploy on prod and dev with the same handler.
I use command
and