fix: handle null value for podData in DeployOdsComponent

serverhorror · May 8, 2024 · fa928c6 · fa928c6
1 parent ce9fdde
commit fa928c6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/org/ods/orchestration/phases/DeployOdsComponent.groovy b/src/org/ods/orchestration/phases/DeployOdsComponent.groovy
@@ -59,15 +59,19 @@ class DeployOdsComponent {
                     applyTemplates(openShiftDir, deploymentMean)
 
                     def retries = project.environmentConfig?.openshiftRolloutTimeoutRetries ?: 10
-                    def podData = []
+                    def podData = null
                     for (def i = 0; i < retries; i++) {
                         podData = os.checkForPodData(project.targetProject, deploymentMean.selector)
                         if (podData) {
                             return podData
                         }
                         steps.echo("Could not find 'running' pod(s) with label '${deploymentMean.selector}' - waiting")
                         steps.sleep(12)
-                    }   
+                    }
+
+                    if podData == null {
+                        throw new RuntimeException("Error: Could not find 'running' pod(s) with label '${deploymentMean.selector}'")
+                    }
 
                     // TODO: What if podData is empty?
                     // TODO: Once the orchestration pipeline can deal with multiple replicas,