Inject global.* values to make them available to release manager

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 * Fix Tailor deployment drifts for D, Q envs ([#1055](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1055))
+* Fix Globally injected variables do not work in subcharts/dependencies ([#1066](https://github.com/opendevstack/ods-jenkins-shared-library/issues/1066))
 
 ## [4.3.4] - 2024-02-20
 

src/org/ods/component/HelmDeploymentStrategy.groovy

@@ -126,9 +126,21 @@ class HelmDeploymentStrategy extends AbstractDeploymentStrategy {
                 // we persist the original ones set from outside - here we just add ours
                 Map mergedHelmValues = [:]
                 mergedHelmValues << options.helmValues
+
+                // we add the global ones - this allows usage in subcharts
+                // TODO: is this really needed? - we could use *just* the global ones
+                // TODO: how do we know we are not overriding something the user defined?
+                options.helmValues.each { key, value ->
+                    mergedHelmValues["global.${key}"] = value
+                }
+
                 mergedHelmValues['imageNamespace'] = targetProject
                 mergedHelmValues['imageTag'] = options.imageTag
 
+                // we also add the predefined ones as these are in use by the library
+                mergedHelmValues['global.imageNamespace'] = targetProject
+                mergedHelmValues['global.imageTag'] = options.imageTag
+
                 // deal with dynamic value files - which are env dependent
                 def mergedHelmValuesFiles = []
                 mergedHelmValuesFiles.addAll(options.helmValuesFiles)