(refactor): replace early return with break and explicit return at th…

…e end requested in: * opendevstack#1108 (comment)
serverhorror · May 13, 2024 · 6cb7307 · 6cb7307
1 parent 2f1dfe3
commit 6cb7307
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/org/ods/orchestration/phases/DeployOdsComponent.groovy b/src/org/ods/orchestration/phases/DeployOdsComponent.groovy
@@ -62,7 +62,7 @@ class DeployOdsComponent {
                     for (def i = 0; i < retries; i++) {
                         podData = os.checkForPodData(project.targetProject, deploymentMean.selector)
                         if (podData) {
-                            return podData
+                            break
                         }
                         steps.echo("Could not find 'running' pod(s) with label '${deploymentMean.selector}' - waiting")
                         steps.sleep(12)
@@ -83,6 +83,7 @@ class DeployOdsComponent {
                     repo.data.openshift.deployments << [(deploymentName): pod]
                     def deploymentMeanKey = deploymentName + '-deploymentMean'
                     repo.data.openshift.deployments << [(deploymentMeanKey): deploymentMean]
+                    return podData
                 }
             } else {
                 def originalDeploymentVersions =