Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] SerpApiClientException: wrong API engine in error message #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix] SerpApiClientException: wrong API engine in error message #47

wants to merge 1 commit into from

Conversation

dimitryzub
Copy link
Contributor

This PR contains a few small fixes that update the engine name in the error message.

Example of incorrect engine name (walmart -> DuckDuckGo):

google-search-results-python/serpapi/duck_duck_go_search.py

Lines 19 to 20 in ce2652b

def get_location(self, q, limit = 5):
raise SerpApiClientException("location is not supported by walmart search engine")

@dimitryzub dimitryzub requested review from ilyazub and jvmvik May 13, 2023 04:50
@dimitryzub dimitryzub self-assigned this May 13, 2023
ilyazub
ilyazub approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyazub ilyazub ilyazub approved these changes

@jvmvik jvmvik Awaiting requested review from jvmvik

Assignees

@dimitryzub dimitryzub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitryzub @ilyazub