Rebranding, efficiency and end-user upgrades 🚀 🚀 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All get_*-family of function are usings stats::window() instead of {xts}-syntax. Local tests shows that {stats} is faster. About 5-10 times faster.
Bug-fix:
If interval were incorrectly specificed the error-message werent rendering properly. This were due to a missing quotation-mark.
Assert: The assert function has been reworked so it only evaluates all statements if any of the values are FALSE. The update is twice as fast as before in cases where all statements are TRUE. Fetch: The fetch()-function is now less defensive and uses only a single try-catch statement. GET: The GET()-function is now less defensive Binance: All possible parameters have been vectorized and/or simplified where possible. General: All ifelse()-functions have been replaced with if () else as these are faster. For cases where more than two if statements are needed, a switch-function is used instead (with default values)
The ByBit API has been upgraded to reduce overhead on if-statements and interval look-up times. See commit 8373bee for more details if there is any interest. > [!NOTE] > > All tests have passed locally.
The Bitmart API has been upgraded to reduce overhead on if-statements and interval look-up times. See commit 8373bee for more details if there is any interest. > [!NOTE] > > All tests have passed locally.
The Crypto.com API has been upgraded to reduce overhead on if-statements and interval look-up times. See commit 8373bee for more details if there is any interest. > [!NOTE] > > All tests have passed locally.
MEXC API have been reworked and vectorized. See commit 8373bee for more infor. Bugfix 🔧 There was a small bug in the SPOT market where values to dates would be passed as scientific values.
Kraken API have been reworked and vectorized. See commit 8373bee for more information. > [!NOTE] > > All tests have passed locally.
Huobi API have been reworked and vectorized. See commit 5a02a40 for more information. > [!NOTE] > > All tests have passed locally.
The available_*-family of functions have been reworked (slightly) and has really minor performance gain. At this stage there is no room for improvement on the coding side - however there are places where redundant codes could be removed, but they act as a defensive measure. These will be addressed at a way later stage.
New feature: ------------ Reading and writing xts-objects using read.zoo and write.zoo under the hood. See the read_xts()- and write_xts()-functions for more details. Added unit tests and updated NEWS.md This function is dedicated to @gokberkcan7 🔥
The README.md now uses data.table for the most part - all checks passes despite not being imported. The exchanges have been recoded, and the available endpoints are being updated dynamically.
The package has a more suitable title and description to reflect it's actual purpose and usecase.
These include, but are not limited to, c(1) and c(foo). In cases like these the values ahve been chaged to 1 and foo. Minor typos and such have been fixed in the README.me
The custom chart vignette is now more user-friendly. It was targeted developers before
serkor1
added a commit
that referenced
this pull request
Jul 7, 2024
* Filter power-up 🔼 🔼
All get_*-family of function are usings stats::window() instead of {xts}-syntax. Local tests shows that {stats} is faster. About 5-10 times faster.
Bug-fix:
If interval were incorrectly specificed the error-message werent rendering properly. This were due to a missing quotation-mark.
* Binance, Assertand Fetch Power-Ups ⬆️ ⬆️
Assert:
The assert function has been reworked so it only evaluates all statements if any of the values are FALSE. The update is twice as fast as before in cases where all statements are TRUE.
Fetch:
The fetch()-function is now less defensive and uses only a single try-catch statement.
GET:
The GET()-function is now less defensive
Binance:
All possible parameters have been vectorized and/or simplified where possible.
General:
All ifelse()-functions have been replaced with if () else as these are faster.
For cases where more than two if statements are needed, a switch-function is used instead (with default values)
* ByBit Power-Ups ⬆️ ⬆️
The ByBit API has been upgraded to reduce overhead on if-statements and
interval look-up times.
See commit 8373bee for more details if there is any interest.
> [!NOTE]
>
> All tests have passed locally.
* Bitmart Power-Ups ⬆️ ⬆️
The Bitmart API has been upgraded to reduce overhead on if-statements and
interval look-up times.
See commit 8373bee for more details if there is any interest.
> [!NOTE]
>
> All tests have passed locally.
* Crypto.com Power-Ups ⬆️ ⬆️
The Crypto.com API has been upgraded to reduce overhead on if-statements and
interval look-up times.
See commit 8373bee for more details if there is any interest.
> [!NOTE]
>
> All tests have passed locally.
* MEXC Power-Ups + Bugfix ⬆️ ⬆️
MEXC API have been reworked and vectorized. See commit 8373bee
for more infor.
Bugfix 🔧
There was a small bug in the SPOT market where values to dates would
be passed as scientific values.
* Kraken Power-Ups ⬆️ ⬆️
Kraken API have been reworked and vectorized. See commit 8373bee for more information.
> [!NOTE]
>
> All tests have passed locally.
* KuCoin Power-Ups ⬆️ ⬆️
MEXC API have been reworked and vectorized. See commit 8373bee
for more information.
Possible bug has been fixed 🔧 (See commit 5a02a40, its similar)
* Huobi (HTX) Power-Ups ⬆️ ⬆️
Huobi API have been reworked and vectorized. See commit 5a02a40
for more information.
> [!NOTE]
>
> All tests have passed locally.
* Endpoint Power-Ups ⬆️ ⬆️
The available_*-family of functions have been reworked (slightly) and has really minor performance gain. At this stage there is no room for improvement on the coding side - however there are places where redundant codes could be removed, but they act as a defensive measure. These will be addressed at a way later stage.
* {cryptoQuotes} Power-Ups ⬆️ ⬆️
New feature:
------------
Reading and writing xts-objects using read.zoo and write.zoo under the hood.
See the read_xts()- and write_xts()-functions for more details.
Added unit tests and updated NEWS.md
This function is dedicated to @gokberkcan7 🔥
* Updated README ⬆️ ⬆️
The README.md now uses data.table for the most part - all checks passes despite not being imported.
The exchanges have been recoded, and the available endpoints are being updated dynamically.
* Updated description and version bump ⬆️ ⬆️
The package has a more suitable title and description to reflect it's actual purpose and usecase.
* Removed redundant operators ⬆️
These include, but are not limited to, c(1) and c(foo). In cases like these the values ahve been chaged to 1 and foo.
Minor typos and such have been fixed in the README.me
* Updated vignette ⬆️ ⬆️
The custom chart vignette is now more user-friendly. It was targeted developers before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All functions, where applicable, have been updated and reworked to be more efficient. With this update the source-code is less defensive in favor of efficiency and speed.
Please see the commit-history for more details. 🚀