Skip to content

Commit

Permalink
Revert "Revert "Merge branch 'development'""
Browse files Browse the repository at this point in the history
This reverts commit 4b60541.
  • Loading branch information
serkor1 committed Mar 12, 2024
1 parent 4b60541 commit bf44f20
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 5 deletions.
21 changes: 17 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,23 @@
## R CMD check results

0 errors ✔ | 0 warnings ✔ | 0 notes ✔
0 errors ✔ | 0 warnings ✔ | 1 note ✖

### The note

```
The Title field should be in title case. Current version is:
'A Streamlined Access to Cryptocurrency OHLC-V Market Data and Sentiment Indicators'
In title case that is:
'A Streamlined Access to Cryptocurrency OHLC-v Market Data and Sentiment Indicators'
```

This `note` is related to `OHLC-V`, and since `OHLC-V` is an accepted shorthand for Open, High, Low, Close and Volume I believe this `note` should
be ignored.

## Resubmission
This is a resubmission. In this version I have:

* Updated the R dependency to >4.x.x, as requested per mail, to pass old-release checks
This is a resubmission. In this version I have updated many elements in the library, but
most importantly the unittests are being conducted in a manner that is robust to timing
errors.


* Updated various functionality of the library
2 changes: 1 addition & 1 deletion vignettes/articles/02-charting.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ BTC <- get_quote(
source = "kraken",
futures = FALSE,
interval = "1h",
from = Sys.Date() - 1
from = Sys.Date() - 7
)
```

Expand Down

0 comments on commit bf44f20

Please sign in to comment.