Connection error 404 Bad Request via proxy #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everytime I tried to conect via a proxy, I was getting a `400 Bad Request` error. Debugging the problem, I found out that the `Str` method of `HTTP::Request` was ignoring the case where the `$.file` field was a copy of the `$.url` field and, because of it, started with `"http"`. The connection was asking my proxy for a `GET /http://etcetc`
|
Ping? |
|
It would be good to get a test on this as I'd like to understand the scenario where this becomes a problem. |
|
@massa could you please provide a test for this change? :) |
|
Hi @sergot ... I will try to do this today or tomorrow. The problem is that the error only occurs with an active proxy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everytime I tried to conect via a proxy, I was getting a
400 Bad Requesterror. Debugging the problem, I found out that theStrmethodof
HTTP::Requestwas ignoring the case where the$.filefield was acopy of the
$.urlfield and, because of it, started with"http". Theconnection was asking my proxy for a
GET /http://etcetc