add specific network/coin/balance types #619
Conversation
| let desired_stake = total_stake / (100 / SERAI_VALIDATORS_DESIRED_PERCENTAGE); | ||
| if stake >= desired_stake { | ||
| Err(Error::<T>::NetworkHasEconomicSecurity)?; | ||
| } |
There was a problem hiding this comment.
Hm. I'm fine kicking this to a separate PR if we can't immediately resolve it, yet I do want to discuss this algorithm more. This limits to 20% of the current stake to external networks. That works if and only if Serai is the last network to be staked for. It does not allow Serai to be the first algorithm to be staked for.
From the initial distribution, we can calculate how much the Serai network should have and simply use that value as the limit.
That has the following quirks in behavior:
- It allows the Serai set to be staked for at an arbitrary point in time, with a much simpler check here
- If various LPs leave (burning the SRI, reducing the amount needed for economic security), then we may have more SRI stake than targeted
In the case of 2, we simply revert to relying on the emissions distribution to maintain the optimal distribution. I do have a concern where a large amount of people stake to the SRI network just to swap to SRI at the spot price. While we're discussing non-trivial slashes re: external networks for offline validators, running a Serai node may only have trivial slashes and is far less annoying to setup a node for. Then since the Serai network is perceived as having infinite capacity, validators can immediately unstake after economic security with their spot-price SRI. The first option (currently implemented) does better in that regard by ensuring the amount staked to SRI is only the amount needed.
Also, further edge case, the final stake which causes economic security is unbounded. This is not too likely to be an issue? But likely yet another reason to open an issue for this and kick it to another PR (and if we do that, I'm fine leaving this here as the initial implementation).
This pr adds new types such as
ExternalNetworkId,ExternalCointo distinctly identify them and help reduce the bugs. These changes helps code readability and prevent us from constantly checking for native network or coin.