Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version #150

Merged
merged 1 commit into from
Aug 28, 2024
Merged

bump version #150

merged 1 commit into from
Aug 28, 2024

Conversation

sdzhong
Copy link
Contributor

@sdzhong sdzhong commented Aug 28, 2024

Change version for App Starts and Screen Loads to demo release comparison--show that the current version versionName 2.11.2 and versionCode 48 is worse than the previous 2.11.1 and 47, as per https://github.com/search?q=repo%3Asentry-demos%2Fandroid+BuildConfig.VERSION_CODE&type=code which adds 1s as per:

if (BuildConfig.VERSION_CODE % 2 == 0) {
  try {
    Thread.sleep(1000);
  } catch (InterruptedException e) {
    throw new RuntimeException(e);
  }
}

@sdzhong
Copy link
Contributor Author

sdzhong commented Aug 28, 2024

image

image

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (8fb9ca1) to head (a37750a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #150   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         15      15           
  Lines        771     779    +8     
  Branches      43      43           
=====================================
- Misses       771     779    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realkosty realkosty self-requested a review August 28, 2024 18:07
Copy link
Contributor

@realkosty realkosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sdzhong sdzhong merged commit f7ce3a9 into main Aug 28, 2024
4 checks passed
@sdzhong sdzhong deleted the 2.11.2 branch August 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants