Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #726

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Update examples #726

merged 7 commits into from
Aug 29, 2023

Conversation

zigaLuksic
Copy link
Collaborator

There is actually a lot less work than I feared there would be

@zigaLuksic zigaLuksic requested a review from mlubej August 28, 2023 14:25
zigaLuksic
zigaLuksic commented Aug 28, 2023
View reviewed changes
Copy link
Collaborator Author

@zigaLuksic zigaLuksic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reverting some things, vscode can be a PITA for this sometimes

examples/core/CoreOverview.ipynb Outdated Show resolved Hide resolved
examples/core/CoreOverview.ipynb Outdated Show resolved Hide resolved
examples/visualization/EOPatchVisualization.ipynb Outdated Show resolved Hide resolved
mlubej
mlubej approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@mlubej mlubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made minor edits, otherwise looked only at the changes, so I'm gonna trust you with the unchanged content, unless you think the examples would benefit from a second comb-through

@zigaLuksic
Copy link
Collaborator Author

Made minor edits, otherwise looked only at the changes, so I'm gonna trust you with the unchanged content, unless you think the examples would benefit from a second comb-through

Thanks. No need for second passes IMO, i ran the notebooks and adjusted fields that produced warnings. If we missed something the users will tell us.

@zigaLuksic zigaLuksic merged commit 3713c59 into develop Aug 29, 2023
7 checks passed
@zigaLuksic zigaLuksic deleted the update-examples branch August 29, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubej mlubej mlubej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zigaLuksic @mlubej