Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single package restructure #698

Merged
merged 21 commits into from
Aug 16, 2023
Merged

Single package restructure #698

merged 21 commits into from
Aug 16, 2023

Conversation

zigaLuksic
Copy link
Collaborator

No description provided.

@zigaLuksic
Copy link
Collaborator Author

The docs get built and I also tested the docker build locally.

@zigaLuksic
Copy link
Collaborator Author

Just to clarify why there are still old folders which only contain requirements and setup.py.
I plan on doing a last 'redirect' release of these subpackages. I have some ideas on what to do, but nothing is final, so I'm keeping these files until that is done. By the time 1.5.0 is released those will be removed.

@devisperessutti devisperessutti self-requested a review June 28, 2023 12:28
mlubej
mlubej reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@mlubej mlubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward to me, nice changes. As mentioned, we still need to figure out how to handle the specific tasks and potentially differently group extras.

I'll also manually check the installation

docs/source/conf.py Show resolved Hide resolved
@zigaLuksic zigaLuksic merged commit a74e150 into develop Aug 16, 2023
7 checks passed
@zigaLuksic zigaLuksic deleted the single-package-restructure branch August 16, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubej mlubej mlubej left review comments

@devisperessutti devisperessutti Awaiting requested review from devisperessutti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zigaLuksic @mlubej