Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers Process #130

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Maintainers Process #130

wants to merge 5 commits into from

Conversation

derekgroh
Copy link
Contributor

Pull Request Checklist

#127

General

  • Update Changelog following the conventions laid out here

Purpose

Addresses a formal maintainers process.

Known Compatibility Issues

None.

@derekgroh derekgroh requested a review from a team as a code owner November 30, 2020 15:46
* archive_file notifies delete directory

* favor Powershell for sensuctl configure

powershell is able to access path variables without additional configuration
powershell_script - use code

* test recipes changes for Github

* cookstyle fixes v7.2.1

* adjust spec to match recipe

* github action - windows

* delete kitchen.appveyor.yml

* split sensuctl test by platform

* update changelog
Copy link
Contributor

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a great swing at it,overall it looks good but I think we need to do a bit of rework as its a bit different since we need an org maintainer from sensu inc to weigh in on this process.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated

##### Process

1. Open an [issue](https://github.com/sensu/sensu-go-chef/issues/new) indicating that you would like to become a maintainer and your subject matter expertise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am honestly not sure what the process should be beyond this, since we need someone at sensu inc with admin permissions to invite to the org 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to tag @cwjohnston or @calebhailey here to give them time to think about it a little

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Abrams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants