Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CVE-2017-17042] update vulnerable yard dependency #76

Merged
merged 1 commit into from
Mar 27, 2018
Merged

[CVE-2017-17042] update vulnerable yard dependency #76

merged 1 commit into from
Mar 27, 2018

Conversation

majormoses
Copy link
Member

Signed-off-by: Ben Abrams [email protected]

Pull Request Checklist

sensu-plugins/community#97

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

Purpose

Address CVE, see parent issue for details

Known Compatibility Issues

none

@majormoses majormoses self-assigned this Mar 23, 2018
@majormoses majormoses requested a review from a team March 23, 2018 20:35
jaredledvina
jaredledvina approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@jaredledvina jaredledvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running out of witty review summaries.

@majormoses
Copy link
Member Author

majormoses commented Mar 27, 2018 •
edited
Loading

I'm running out of witty review summaries.

"Ideas run out have you?"
- what I'd imagine yoda saying

Might I suggest something like this in the future: https://pungenerator.org for additional inspriration

@majormoses majormoses merged commit 7dce6a1 into master Mar 27, 2018
@majormoses majormoses deleted the fix/CVE-2017-17042 branch March 27, 2018 19:45
@majormoses
Copy link
Member Author

released: https://rubygems.org/gems/sensu-plugins-network-checks/versions/3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huynt1979 huynt1979 huynt1979 approved these changes

@jaredledvina jaredledvina jaredledvina approved these changes

Assignees

@majormoses majormoses

Labels
Status: Needs Review Type: Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majormoses @huynt1979 @jaredledvina