Address multiple CVE's #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address the following CVE's: - https://nvd.nist.gov/vuln/detail/CVE-2017-17042 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418 Breaking Changes: - removed ruby versions `< 2.3` support Misc Changes: - appeased the cops - target rubocop rules to ruby 2.3 - update changelog guidelines locations Signed-off-by: Ben Abrams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the following CVE's:
Breaking Changes:
< 2.3supportMisc Changes:
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Address CVE's, misc cleanup
Known Compatibility Issues
removed
< 2.3ruby version support.