POST method fix, Now HttpHandler is called for POST, and fix for Websocket on latest Safari #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith Invalid HTTP version string: HTTP/1.0 error
ummarbhutta
changed the title
… refactoring + HttpRequestProcessor class refactoing
…ata fetching + Single session deletion logic update
…nd HybridSessionStorageHandler class code update and fixes)
…e duplicate sessions.
… into session_support
…Session files storage path creation issue fixes
2- HttpHandlerBase abstract class for availability of Request, Response, and Session Handler through out the inherited handler rather than passing as parameter to 'Handle Request' method.
…nDataCache type update to dictionary of objects to handle complex data.
Session support implementation
- We need a new instance of HttpRequestHandler for every request to handle this situation, For now there is one instance only which is logically incorrect and request/response get corrupted in case of parallel requests - A Factory class could be a solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for Bug #6 as well as fix for WebSocket handshake issue on the Safari browser latest version using IPad Pro, same issue is thrown on Mac book pro using Safari Version 10.0.1 (11602.2.14.0.7), It is due to reason of wrong HTTP version sent in upgrade to web-socket response. Expected value is HTTP/1.1 but HTTP/1.0 is returned from this server. After this fix it is working fine on IPad and all other major browsers.
Snapshot of web-socket error on 4shared.com