Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve underlying type to detect overflows in type aliases #1170

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

gartnera
Copy link
Contributor

Calling Underlying() will get the underlying type if there is one.

This allows correctly testing for overflows with type aliases.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.52%. Comparing base (4487a0c) to head (01c7d9a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   69.52%   69.52%           
=======================================
  Files          71       71           
  Lines        3865     3865           
=======================================
  Hits         2687     2687           
  Misses       1061     1061           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccojocar ccojocar merged commit 08b94f9 into securego:master Jul 20, 2024
6 checks passed
@gartnera gartnera deleted the g115-underlying branch July 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants