Feature: Rule G401 split into two different rules #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2024 15:58
The corresponding CWE from G401 rule was changed from CWE-326 -> CWE-328. In my opinion, this CWE suits better the rule.
Now the G401 rule is split into hashing and encryption algorithms. G401 is responsible for checking the usage of MD5 and SHA1, with corresponding CWE of 328. And G405(New rule) is responsible for checking the usege of DES and RC4, with corresponding CWE of 327.
* Renamed the file responsible for rule G401 * Removed copyright of HP from the new rule
ccojocar
approved these changes
Jun 23, 2024
|
@expp121 There seems to be some lint warnings, please could you fix them. I think the test file needs to be formatted. Thanks |
The CI workflow wasn't able to complete succesfully. * Formatted the call_list_test.go file
|
Thank you for the advice @ccojocar! I hope I've fixed (quite new to github actions) the issue with the most recent commit. I would also like to ask whether the analyzer_test.go file, should contain a license of some sort? |
* Renamed file(removed space) * Changed the expected issues ( 1 -> 2)
@expp121 Yeah, it should have the same Apache license header file like the other files with an updated year. Please could you add it? Thanks a lot |
ccojocar
approved these changes
Jun 24, 2024
|
@expp121 I'll merge this. You can add the license header in a separate PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rule G401 is used both for encryption and hashing algorithms, this might result in wrong categorization of a weakness.
This pull request aims to solve that problem, by splitting the rule into two separate ones(G401, G405).
Rule G401 is now responsible for only checking hashing algorithms such as MD5 and SHA1. Code containing those algorithms is flagged with CWE-328.
And the new rule G405 is responsible for checking encryption algorithms such as DES and RC4. And it flags code containing them with CWE-327.
closes #1158