Fix test that checks the overridden nosec directive

analyzer.go

@@ -537,7 +537,12 @@ func (gosec *Analyzer) ignore(n ast.Node) map[string]issue.SuppressionInfo {
 	if groups, ok := gosec.context.Comments[n]; ok && !gosec.ignoreNosec {
 
 		// Checks if an alternative for #nosec is set and, if not, uses the default.
-		noSecDefaultTag := NoSecTag(string(Nosec))
+		noSecDefaultTag, err := gosec.config.GetGlobal(Nosec)
+		if err != nil {
+			noSecDefaultTag = NoSecTag(string(Nosec))
+		} else {
+			noSecDefaultTag = NoSecTag(noSecDefaultTag)
+		}
 		noSecAlternativeTag, err := gosec.config.GetGlobal(NoSecAlternative)
 		if err != nil {
 			noSecAlternativeTag = noSecDefaultTag

analyzer_test.go

@@ -306,21 +306,21 @@ var _ = Describe("Analyzer", func() {
 			Expect(nosecIssues).Should(HaveLen(sample.Errors))
 		})
 
-		XIt("should be possible to overwrite nosec comments, and report issues but the should not be counted", func() {
+		It("should be possible to overwrite nosec comments, and report issues but they should not be counted", func() {
 			// Rule for MD5 weak crypto usage
 			sample := testutils.SampleCodeG401[0]
 			source := sample.Code[0]
 
 			// overwrite nosec option
 			nosecIgnoreConfig := gosec.NewConfig()
-			nosecIgnoreConfig.SetGlobal(gosec.Nosec, "true")
+			nosecIgnoreConfig.SetGlobal(gosec.Nosec, "mynosec")
 			nosecIgnoreConfig.SetGlobal(gosec.ShowIgnored, "true")
 			customAnalyzer := gosec.NewAnalyzer(nosecIgnoreConfig, tests, false, false, 1, logger)
 			customAnalyzer.LoadRules(rules.Generate(false, rules.NewRuleFilter(false, "G401")).RulesInfo())
 
 			nosecPackage := testutils.NewTestPackage()
 			defer nosecPackage.Close()
-			nosecSource := strings.Replace(source, "h := md5.New()", "h := md5.New() //#nosec", 1)
+			nosecSource := strings.Replace(source, "h := md5.New()", "h := md5.New() // #mynosec", 1)
 			nosecPackage.AddFile("md5.go", nosecSource)
 			err := nosecPackage.Build()
 			Expect(err).ShouldNot(HaveOccurred())

flag_test.go

@@ -13,17 +13,19 @@ import (
 var _ = Describe("Cli", func() {
 	Context("vflag test", func() {
 		It("value must be empty as parameter value contains invalid character", func() {
-			os.Args = []string{"gosec", "-test1=-incorrect"}
+			os.Args = []string{"gosec", "-flag1=-incorrect"}
 			f := vflag.ValidatedFlag{}
-			flag.Var(&f, "test1", "")
-			flag.CommandLine.Init("test1", flag.ContinueOnError)
+			flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ContinueOnError)
+			flag.Var(&f, "falg1", "")
+			flag.CommandLine.Init("flag1", flag.ContinueOnError)
 			flag.Parse()
 			Expect(flag.Parsed()).Should(BeTrue())
 			Expect(f.Value).Should(Equal(``))
 		})
 		It("value must be empty as parameter value contains invalid character without equal sign", func() {
 			os.Args = []string{"gosec", "-test2= -incorrect"}
 			f := vflag.ValidatedFlag{}
+			flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ContinueOnError)
 			flag.Var(&f, "test2", "")
 			flag.CommandLine.Init("test2", flag.ContinueOnError)
 			flag.Parse()