Harmonize Envoy CLI and Configuration Files with Director Component for Consistency #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR harmonizes Envoy CLI and configuration files to ensure similarity and consistency with Director component, and also introduces error handling by adding specific exceptions for Envoy configuration
Change Description:
• Updated the Envoy CLI commands by removing the
director_hostanddirector_portparameters. These parameters (director_hostanddirector_port) are now provided in the Envoy ConfigYAMLfile.• Updated the Envoy configuration files of the Federated-Runtime workspace by including the
director_hostanddirector_portparameters in the ConfigYAML• This approach ensures consistency with Director component and simplifies the CLI command line
• Incorporated error handling for invalid inputs in
director_hostanddirector_port, raising specific exceptions for invalid or missing values to improve configuration validation.Modifications:
Source Code
openfl/experimental/workflow/component/envoy/envoy.pyopenfl/experimental/workflow/interface/cli/envoy.pyTutorials
openfl-tutorials/experimental/workflow/FederatedRuntime/301_MNIST_Watermaking/Bangalore/Bangalore_config.yamlopenfl-tutorials/experimental/workflow/FederatedRuntime/301_MNIST_Watermaking/Bangalore/start_envoy.shopenfl-tutorials/experimental/workflow/FederatedRuntime/301_MNIST_Watermaking/Chandler/Chandler_config.yamlopenfl-tutorials/experimental/workflow/FederatedRuntime/301_MNIST_Watermaking/Chandler/start_envoy.shopenfl-tutorials/experimental/workflow/FederatedRuntime/101_MNIST/Portland/Portland_config.yamlopenfl-tutorials/experimental/workflow/FederatedRuntime/101_MNIST/Portland/start_envoy.shopenfl-tutorials/experimental/workflow/FederatedRuntime/101_MNIST/Seattle/Seattle_config.yamlopenfl-tutorials/experimental/workflow/FederatedRuntime/101_MNIST/Seattle/start_envoy.shTest Cases
tests/github/experimental/workflow/FederatedRuntime/testcase_datastore_cli/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_datastore_cli/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_datastore_cli/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_datastore_cli/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_include_exclude/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_include_exclude/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_include_exclude/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_include_exclude/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_internalloop/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_internalloop/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_internalloop/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_internalloop/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_with_both_options/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_with_both_options/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_with_both_options/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_with_both_options/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_without_callable/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_without_callable/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_without_callable/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_private_attributes_initialization_without_callable/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_reference/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_reference/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_reference/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_reference/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_reference_with_include_exclude/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_reference_with_include_exclude/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_reference_with_include_exclude/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_reference_with_include_exclude/envoy_two/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_four/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_four/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_one/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_one/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_three/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_three/start_envoy.shtests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_two/envoy_config.yamltests/github/experimental/workflow/FederatedRuntime/testcase_subset_of_collaborators/envoy_two/start_envoy.shDocumentation
docs/about/features_index/workflowinterface.rstValidation:
Executed following tutorials to ensure that the change is working properly:
openfl-tutorials/experimental/workflow/FederatedRuntime/101_MNISTopenfl-tutorials/experimental/workflow/FederatedRuntime/301_MNIST_Watermaking