Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getAsJson() #725

Merged
merged 48 commits into from
Oct 22, 2024
Merged

Refactor getAsJson() #725

merged 48 commits into from
Oct 22, 2024

Conversation

fabianbs96
Copy link
Member

In the process to make nlohmann::json and implementation detail (and not having any nlohmann type in our public APIs), we:

  1. Deprecate all getAsJson() functions
  2. Add printAsJson() functions that should be used instead.

mxHuber and others added 30 commits March 13, 2024 23:56
@mxHuber
unresolved ref to F/NToString
d3b3172
@mxHuber
compiles
0912f5c
@mxHuber
refactored CallGraph::deserialize()
3be40ea
@mxHuber
refactored unittests, all fail
86fc715
@mxHuber
all unittests finally pass
3ecb12a
@mxHuber
code cleanup
3664d3f
@mxHuber
refactoring
ef50e02
@mxHuber
fixed function with no caller not being serialized
36ae5b9
@fabianbs96 @mxHuber
Fix Dependendency Installation (secure-software-engineering#707)
7af57e4 
* Do not install phasar's dependencies to the global namespace anymore

* fix for in-tree build

* out-factor the inclusion of LLVM and clang to a separate cmake file

* Make PHASAR_CONFIG_INSTALL_DIR respect the CMAKE_INSTALL_PREFIX, even if that is not set at configure time

* Fix in-tree build
@mxHuber
backup DIBTH Data
a4091ca
@mxHuber
DIBTH serialization code, untested
1d9ea9b
@mxHuber
DIBTHData getDataFromJson Impl
1cb3345
@mxHuber
improved de-/serialization impl w/o TypeToVertex
d828566
@mxHuber
fixed DIBTHData TypeToVertex not compiling
751366f
@mxHuber
fixed serialization bugs and unittests
6e37cd3
@mxHuber
DITHS Test fixes, 13 pass, 11 fail
8708a76
@mxHuber
DIBTH Ser Test, 1 failing Test left
50d966a
@mxHuber
GeneralStatisticsAnalysisData impl
9d81f4e
@mxHuber
LLVMAliasSetData impl
643da4b
@mxHuber
last printAsJson Impls
7f79712
@mxHuber
Final Impls, DIBTH Identifier Impl not working
a347b7d
@mxHuber
changes + fixes from meeting
b4c8ff3
@mxHuber
no equality of values DIBTH Test
c835961
@mxHuber
fixed all bugs, all unittests pass
7f6194e
@fabianbs96
Merge branch 'development' into f-GetAsJsonRefactor
4fc243a
@fabianbs96
Fix crash in buildTypeGraph in the presence of typedefs
16bbf2a
@mxHuber
fixed LLVMAliasSetSerializationTest
47bf183
@fabianbs96
Add more aggressive composite type filter
767a90e
@fabianbs96
Refactor handling of DI type names
fe605e9
@fabianbs96
Implicit vertex index
53e222e
@fabianbs96 fabianbs96 self-assigned this May 20, 2024
@fabianbs96 fabianbs96 requested a review from MMory as a code owner May 20, 2024 12:37
@fabianbs96 fabianbs96 mentioned this pull request May 20, 2024
Closed
MMory
MMory approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the minor things before merging.

include/phasar/ControlFlow/CallGraphData.h Outdated Show resolved Hide resolved
lib/PhasarLLVM/TypeHierarchy/DIBasedTypeHierarchy.cpp Show resolved Hide resolved
lib/PhasarLLVM/TypeHierarchy/DIBasedTypeHierarchy.cpp Outdated Show resolved Hide resolved
@fabianbs96 fabianbs96 merged commit f17594d into secure-software-engineering:development Oct 22, 2024
5 checks passed
@fabianbs96 fabianbs96 deleted the f-GetAsJsonRefactor branch October 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMory MMory MMory approved these changes

Assignees

@fabianbs96 fabianbs96

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianbs96 @MMory @mxHuber