Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TypeHierarchy Interface #721

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

fabianbs96
Copy link
Member

The TypeHierarchy Interface needs some refactoring. This PR does the following:

  • Split the VTable handling out of the TypeHierarchy interface
  • Modernize some API functions from the TypeHierarchy
  • Integrate the API changes into the LLVMBasedICFG

@@ -51,10 +51,10 @@ getReceiverType(const llvm::CallBase *CallSite);

class Resolver {
protected:
LLVMProjectIRDB &IRDB;
LLVMTypeHierarchy *TH;
const LLVMProjectIRDB *IRDB;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it a pointer now?

Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@MMory MMory merged commit 59f257a into development May 28, 2024
5 checks passed
@MMory MMory deleted the f-RefactorTypeHierarchyInterface branch May 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants