Also compare gep type in IIA EqualGEPDescriptor

secure-software-engineering · Aug 9, 2024 · b4783b9 · b4783b9
1 parent d482f4d
commit b4783b9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.cpp b/lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.cpp
@@ -109,7 +109,8 @@ bool IDEIIAFlowFact::operator==(const IDEIIAFlowFact &Other) const {
   }
   auto EqualGEPDescriptor = [](const llvm::GetElementPtrInst *Lhs,
                                const llvm::GetElementPtrInst *Rhs) {
-    return llvm::equal(Lhs->indices(), Rhs->indices());
+    return Lhs->getSourceElementType() == Rhs->getSourceElementType() &&
+           llvm::equal(Lhs->indices(), Rhs->indices());
   };
   for (unsigned Idx = 0; Idx < FieldDesc.size(); ++Idx) {
     if (!EqualGEPDescriptor(FieldDesc[Idx], Other.FieldDesc[Idx])) {