Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastUpdateModel docstrings #627

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix FastUpdateModel docstrings #627

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
032a9a5
Fix FastUpdateModel docstrings
st-- Sep 20, 2022
d686ff0
Merge branch 'develop' into patch-1
hstojic Jul 5, 2023
7e1a427
Merge branch 'develop' into patch-1
hstojic Aug 2, 2023
a13ab1d
Merge branch 'develop' into patch-1
hstojic Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions trieste/models/interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def conditional_predict_f(
:param additional_data: Dataset with query_points with shape [..., N, D] and observations
with shape [..., N, L]
:return: The mean and variance of the independent marginal distributions at each point in
``query_points``, with shape [..., L, M, M].
``query_points``, with shape [..., M, L] each.
"""
raise NotImplementedError

Expand All @@ -283,7 +283,7 @@ def conditional_predict_joint(
:param additional_data: Dataset with query_points with shape [..., N, D] and observations
with shape [..., N, L]
:return: The mean and covariance of the joint marginal distribution at each batch of points
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what is the "joint marginal distribution"? is this the joint distribution over all fs? So should this be

Suggested change
:return: The mean and covariance of the joint marginal distribution at each batch of points
:return: The mean and covariance of the joint distribution at each batch of points

?

in ``query_points``, with shape [..., L, M, M].
in ``query_points``, with shape [..., M, L] and [..., L, M, M], respectively.
"""
raise NotImplementedError

Expand Down