Improve tests for SourceMapper
#6113
Closed
+194
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
changed the title
dantleech
commented
Jan 29, 2025
dantleech
commented
Jan 29, 2025
dantleech
commented
Jan 29, 2025
Once the build is green and you tell me this is good to go, I will take care of cherry-picking this into For a clean(er) history, I would appreciate it if you could squash these changes into a single commit. Sorry for the inconvenience. |
sebastianbergmann
added
the
type/enhancement
sebastianbergmann
changed the title
SourceMapper
dantleech
force-pushed
the
gh-6111-source-mapper-test
branch
from
a99a217 to
c0f0771
Compare
- Created a static factory method for `Source` to remove the redundant constructor arguments. - Created a static helper method to resolve the fixture path. - Test prefix inclusion and exlusion - Test suffix inclusion and exlusion
dantleech
force-pushed
the
gh-6111-source-mapper-test
branch
from
c0f0771 to
89391ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6113 +/- ##
=========================================
Coverage 95.07% 95.07%
Complexity 6730 6730
=========================================
Files 724 724
Lines 21195 21195
=========================================
Hits 20151 20151
Misses 1044 1044 ☔ View full report in Codecov by Sentry. |
|
Thank you! I'll take care from here. |
|
Cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I hope I haven't been overzealous in refactoring the test, let me know if you want me to revert it to the original format.
Would this be against main or a previous version?