Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pine64 Star64 #174

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

Ivan-Velickovic
Copy link
Contributor

The motivation for using a binary image is that it is (in my experience) the most stable.

@axel-h
Copy link
Member

axel-h commented Aug 21, 2023

What does is mean "most stable"? Can you make this a bit more specific, is it the OpenSBI build/boot flow that works better? Or the U-Boot boot flow? Or the platform specific tooling?

@Ivan-Velickovic
Copy link
Contributor Author

What does is mean "most stable"? Can you make this a bit more specific, is it the OpenSBI build/boot flow that works better? Or the U-Boot boot flow? Or the platform specific tooling?

I meant just in general, with a binary image you just set the program counter and jump to it whereas with an ELF or other file formats their is more space to get things wrong. One example I've had in the past when using bootelf with U-Boot is that it just doesn't do anything, no error message or nothing.

In addition, a binary works with the regular boot flow of the Star64 but also with FW_PAYLOAD and FW_JUMP with OpenSBI.

@@ -56,6 +59,9 @@ function(ApplyData61ElfLoaderSettings kernel_platform kernel_sel4_arch)
endif()
set(IMAGE_START_ADDR 0x10000000 CACHE INTERNAL "" FORCE)
endif()
if(KernelPlatformStar64)
set(IMAGE_START_ADDR 0x60000000 CACHE INTERNAL "" FORCE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment where this address comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what I would say because it comes from the same place as all the other addresses in that file - somewhere in RAM that doesn't overlap with anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, could say this for the whole section then, that it's an arbitrary choice unless stated otherwise. That answer feels lika a deja-vu somehow.

Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Signed-off-by: Ivan-Velickovic <[email protected]>
@Ivan-Velickovic Ivan-Velickovic merged commit 5c3ff84 into seL4:master Jun 11, 2024
20 checks passed
@Ivan-Velickovic Ivan-Velickovic deleted the star64 branch June 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants