Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camkes-vm: avoid exception when BAMBOO is not set #362

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Aug 13, 2024

Since we are enumerating builds, it is possible that BAMBOO is not set, leading to an exception when deleting this (unused) key. Therefore check for presence before deleting.

(#361 broke the camkes-vm build because of this)

Since we are enumerating builds, it is possible that BAMBOO is not set,
leading to an exception when deleting this (unused) key. Therefore check
for presence before deleting.

Signed-off-by: Gerwin Klein <[email protected]>
Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other scripts here that also do this unconditionally, too?

@lsf37
Copy link
Member Author

lsf37 commented Aug 13, 2024

Are there other scripts here that also do this unconditionally, too?

At least none have failed yet, but you're right I should have a look at that.

@lsf37 lsf37 merged commit 3962889 into master Aug 13, 2024
7 checks passed
@lsf37 lsf37 deleted the camkes-vm-fix branch August 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants