ridale/lwip #13
ridale/lwip #13
Conversation
Signed-off-by: Richard Lemon <[email protected]>
Signed-off-by: Richard Lemon <[email protected]>
Signed-off-by: Richard Lemon <[email protected]>
|
Hi @ridale, thanks for raising the PR. Is there an expected way for providing
We could leave this as an example of an application that links an lwip instance into itself. Then you could use it in a system where the ethdriver component presents multiple ethernet MAC adresses with each client component having a separate, isolated networking stack? |
|
Hi @kent-mcleod sorry about the delay been working on getting the USB stack to work on sabre. happy to leave this as is as an example. |
|
|
||
| static void malloc_dma_unpin(void *cookie, void *addr, size_t size) | ||
| { | ||
| } |
There was a problem hiding this comment.
For empty functions, pleas add a comment in the body that they are empty on purpose. So it's clear the contain was not lonst somewhere during merging or rebasing or. The parameters should also be flagged as unused to silence compiler warnings.
| @@ -0,0 +1,43 @@ | |||
| #include <camkes.h> | |||
There was a problem hiding this comment.
Please add a header with copyright infos (author, license).
| /* Start the timer for the TCP stack */ | ||
| timer_periodic(0, NS_IN_MS * LWIP_TICK_MS); | ||
| } | ||
| /* Callback that gets called when the timer fires. */ |
There was a problem hiding this comment.
please add an empty line before the comment
| { | ||
| int retval = 0; | ||
| return retval; | ||
| } |
There was a problem hiding this comment.
please add a a line break at the end of the file
|
Sorry this is an old pull request that I am getting to work again with the newer version of seL4 and probably doesn't warrant reviewing at the moment. It builds but I have not tested it on hardware and will not be able to for some time. If you would like you can close this pull request and I will reopen it if I get a chance to look at it again. I understand from one of your issue reports seL4/util_libs#68 that you would like to pull lwip support, there are the same problems with cached dma in the camkes global component code as well. I think that is one of my other pull requests. |
|
I've set the PR as draft to mark that you're intending further work, so we can leave it open for now. |
| # the BSD 2-Clause license. Note that NO WARRANTY is provided. | ||
| # See "LICENSE_BSD2.txt" for details. | ||
| # | ||
| # @TAG(DATA61_BSD) |
There was a problem hiding this comment.
This is obsolete, please use:
| # @TAG(DATA61_BSD) | |
| # SPDX-License-Identifier: BSD-2-Clause |
There was a problem hiding this comment.
In this case (because it is "ours") the rest of the header should be collapsed as well into just the copyright line and SPDX identifier like in the rest of the sources.
| * the BSD 2-Clause license. Note that NO WARRANTY is provided. | ||
| * See "LICENSE_BSD2.txt" for details. | ||
| * | ||
| * @TAG(DATA61_BSD) |
There was a problem hiding this comment.
This is obsolete, please use:
| * @TAG(DATA61_BSD) | |
| * SPDX-License-Identifier: BSD-2-Clause |
This project uses the ethdriver global component and liblwip to provide a UDP echo server.
It was taken, in part from the camkes-apps-ethernet-demo-x86--devel but currently only works with EthdriverARMPlat as I pulled the x86 camkes #defs during debugging.
It would be reasonable to push the eth_interface.c code into a lwipserver similar to the picoserver global component. I could not however figure out a clean interface for binding traffic handlers to the interface between an app component and the any global lwipserver component.
I am happy to be directed on how this should look.