Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parent and Child Within One Commit #80

Draft
wants to merge 2 commits into
base: vara-dev
Choose a base branch
from

Conversation

s9latimm
Copy link
Member

M	include/vara/Feature/FeatureModelTransaction.h
M	lib/Feature/FeatureModelTransaction.cpp
M	unittests/Feature/FeatureModelTransaction.cpp
@s9latimm s9latimm requested review from vulder and MiriamMarx and removed request for vulder January 14, 2022 09:43
@s9latimm s9latimm changed the title Extend addFeatures to add parent and child within one commit Extend addFeatures to Add Parent and Child Within One Commit Jan 14, 2022
@s9latimm s9latimm changed the title Extend addFeatures to Add Parent and Child Within One Commit Add Parent and Child Within One Commit Jan 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #80 (293c796) into vara-dev (8721dc8) will increase coverage by 0.38%.
The diff coverage is 98.30%.

❗ Current head 293c796 differs from pull request most recent head 1d55b41. Consider uploading reports for the commit 1d55b41 to get more accurate results

@@             Coverage Diff              @@
##           vara-dev      #80      +/-   ##
============================================
+ Coverage     88.48%   88.87%   +0.38%     
============================================
  Files            48       48              
  Lines          5282     5608     +326     
============================================
+ Hits           4674     4984     +310     
- Misses          608      624      +16     
Impacted Files Coverage Δ
include/vara/Feature/FeatureModelTransaction.h 85.29% <95.45%> (+0.15%) ⬆️
lib/Feature/FeatureModelTransaction.cpp 84.83% <100.00%> (+0.62%) ⬆️
unittests/Feature/FeatureModelTransaction.cpp 99.39% <100.00%> (+0.02%) ⬆️
include/vara/Feature/FeatureSourceRange.h 88.18% <0.00%> (-3.02%) ⬇️
include/vara/Feature/FeatureModelParser.h 85.71% <0.00%> (-1.79%) ⬇️
unittests/Feature/FeatureSourceRange.cpp 100.00% <0.00%> (ø)
lib/Feature/FeatureModelParser.cpp 92.16% <0.00%> (+1.42%) ⬆️
include/vara/Feature/FeatureModel.h 87.31% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8721dc8...1d55b41. Read the comment docs.

@s9latimm s9latimm marked this pull request as draft April 29, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants