Support for astra dr17 spectra #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #48, closes #45. It updates the models and queries for the new
vizdb.sdssid_to_pipestable schema, which includes the astrarelease:dr17orsdss5, and themjdof data reduction. It also exposes a newin_bvsfield to indicate if the sdss_id is in the astra_050.boss_visit_spectrum table. This will help differentiate fromin_boss, which indicates if it's in the boss_drp.boss_spectrum table.It also includes support for loading dr17 apStar files for sdss_ids that don't have MWM data. This is necessary for astra reductions coming from dr17 apogee spectra and not MWM.