Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove build.py #36

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore: Remove build.py #36

merged 1 commit into from
Aug 5, 2024

Conversation

albireox
Copy link
Member

@albireox albireox commented Aug 5, 2024

Installing the project now fails with error

Installing the current project: sdss-valis (0.1.1-alpha)
Preparing build environment with build-system requirements poetry>=1.0.0
/tmp/tmpfmj9ebia/.venv/bin/python: can't open file '/home/runner/work/valis/valis/build.py': [Errno 2] No such file or directory

Command ['/tmp/tmpfmj9ebia/.venv/bin/python', '/home/runner/work/valis/valis/build.py'] errored with the following return code 2
Error: Process completed with exit code 1.

even if the build.py file exists. This may be related to the new python-build package that is part of the setuptools echosystem, or a change in Poetry. Since build.py is just a placeholder from the python-template and we don't use it in Valis (we don't have any C extensions), the easiest is to remove it.

@albireox albireox requested a review from havok2063 as a code owner August 5, 2024 15:46
@albireox albireox changed the title Remove build.py chore: Remove build.py Aug 5, 2024
@havok2063 havok2063 merged commit ec291e4 into main Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants