-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theta1 #4
Open
Sean-Morrison
wants to merge
13
commits into
main
Choose a base branch
from
theta1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Theta1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced pkg_resources with importlib to resolve a hidden dependency with setuptools
Correct SDSSC2VB to SDSSC2BV column header and add description for unused bit 0
Update Jinja2
I'm happy for this to be merged now if you still are @Sean-Morrison (You should be able to merge it in if you want.) Next year I will need to fix the build for tests |
Add basic logging and update the mapping cached_class_property to use a cached mapping path rather then building the path again
add basic logging and fix bug that keeps set_version from running for each class instance with the same version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add theta1 cartons to the mapping and update the code for the versioning of the mapping file. Added description of the unset bit 0 in the mapping. Update jinja2 to resolve security vulnerability. Replaced pkg_resources with import lib to resolve a hidden dependency