-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dpdk-update #337
Open
marascoben
wants to merge
21
commits into
sdnfv:develop
Choose a base branch
from
marascoben:feature/dpdk-update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/dpdk-update #337
+1,050
−2,132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the source IP address in ARP reply from CPU byte ordering to BE. Commit log: * ARP endianess fixed
Release of ONVM v21.10
marascoben
force-pushed
the
feature/dpdk-update
branch
8 times, most recently
from
August 27, 2024 00:06
dc84746
to
80c83e8
Compare
marascoben
force-pushed
the
feature/dpdk-update
branch
from
August 27, 2024 00:13
80c83e8
to
e823acd
Compare
marascoben
force-pushed
the
feature/dpdk-update
branch
from
September 10, 2024 04:14
dec9b5d
to
c3f1bf4
Compare
marascoben
force-pushed
the
feature/dpdk-update
branch
from
September 10, 2024 04:21
c3f1bf4
to
06e732f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DPDK to version 24.0, and convert onvm to the Meson build system.
Summary:
This updates ONVM to use the latest version of DPDK, which no longer uses the same Makefile structure that ONVM was based upon. The build system was converted to Meson (dpdk's new build system) for onvm_mgr, onvm_lib, onvm_nflib, and almost all example NFs.
(Flow table, ndpi stats, and NFD all required extra work to move to Meson, and will be done separately under a separate task)
A number of breaking changes were introduced to DPDK APIs that have been resolved:
Major Changes
Minor Changes
split_header_size
field forRTE_ETH_RX_OFFLOAD_HEADER_SPLIT
has been removed, as no drivers actually supported this feature see DPDK change hereRTE_
prefix, the associated variable in ONVM have been updated to include the rename see DPDK change heremax_rx_pkt_len
field has been moved tomtu
as described in this DPDK commitThis change also adds the DPDK
igb_uio
driver as a new dependency, as DPDK no longer ships with kernel drivers included.The main README.md file has also been updated to reflect the new build system, and links to documentation within the readme have been updated.
This change also fixes #333 and resolves #336
Usage:
Merging notes:
TODO before merging :
Test Plan:
Testing was performed by running onvm_mgr and the bridge nf to validate packets could pass through the TX and RX fields. More testing of ONVM will be required in the wild to fully validate that all changes made by DPDK do not break edge cases within onvm.
No errors were observed during testing.
Tests were also validated in Cloudlab.
Review:
@twood02