Display packet drop stats #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisafa
reviewed
Oct 29, 2021
| struct rte_eth_stats stat; | ||
| if (rte_eth_stats_get(ports->id[i], &stat)) | ||
| RTE_LOG(ERR, APP, "Cannot get stats of port %d\n", ports->id[i]); | ||
| ports->nic_drop[ports->id[i]] = stat.imissed + stat.ierrors; |
There was a problem hiding this comment.
Adding on to this, I think it'd be helpful to include the received and transmitted bytes (ibytes and obytes)
There was a problem hiding this comment.
@dennisafa I think it is easy to add more stats, as you suggested, but I don't know where those stats could be displayed :)
There was a problem hiding this comment.
They can be displayed with the other NIC stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a code I've used so far to display packet drop stats at the NIC.
Best.