Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status filtering for Series #3952

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add status filtering for Series #3952

wants to merge 6 commits into from
+174 −2

Conversation

kage1414
Copy link

@kage1414 kage1414 commented Oct 10, 2024 •
edited
Loading

Description

Adds status filtering for Series and not Movies
There is no reliable and performant way to successfully filter movies by status. This will be moved to another issue until unblocked by TMDB

  • Adds discover/status/tv endpoint
    • Returns status enum
  • Adds status input field in filter panel for TV only
  • <StatusSelector /> functions similarly to <GenreSelector /> (not multi)

Screenshot (if UI-related)

Screenshot 2024-10-10 104454
Screenshot 2024-10-10 104504

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@kage1414
feat(discover tv): adds status filter to discover tv
f24d48f
@kage1414
fix(remove status filtering from movies): hides status filter in movies
88d6617 
TMDB doesn't support status filtering, status input field is hidden until supported in TMDB
@kage1414
fix(remove movie status. fix language): removes movie status endpoint…
5ef0513 
…s. fixes language

Fully disables the ability to filter by movies status and removes endpoints. Updates language
leftover from copying genre selector for use in status selector
@kage1414
fix(fix language): fix placeholder language
f83d1ab 
update placeholder language to Select status...
@kage1414
refactor(removes options state): removes state previously only used f…
ad69a40 
…or setting the default value
@kage1414
refactor(add i18n keys): adds translation keys
3acd942
@kage1414 kage1414 marked this pull request as ready for review October 10, 2024 15:05
@kage1414 kage1414 changed the title Add status filtering Add status filtering for Series Oct 10, 2024
@kage1414 kage1414 mentioned this pull request Oct 10, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct Awaiting requested review from sct sct is a code owner

@TheCatLady TheCatLady Awaiting requested review from TheCatLady TheCatLady is a code owner

@danshilm danshilm Awaiting requested review from danshilm danshilm is a code owner

@OwsleyJr OwsleyJr Awaiting requested review from OwsleyJr OwsleyJr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Status filtering
1 participant
@kage1414