Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop around transformed segmentation #89

Merged
merged 2 commits into from
Oct 31, 2020
Merged

Crop around transformed segmentation #89

merged 2 commits into from
Oct 31, 2020

Conversation

PaulBautin
Copy link
Collaborator

@PaulBautin PaulBautin commented Oct 27, 2020

This PR aims to implement: #88 (comment). Up to know cropping was performed around a dilated initial segmentation. The new method transforms initial segmentation before cropping image, this ensures spinal cord does not exceed image boundaries.

DONE:

  • transform and dilate the labelled segmentation to crop image
  • update csa_rescale_stat.py, extract the "rescale" from updated "Filename"

FIX #88

@jcohenadad
Copy link
Member

@PaulBautin is it ready for review?

@PaulBautin
Copy link
Collaborator Author

Yes, it was tested on a 2 subjects that caused issues in precedent runs.

@PaulBautin
Copy link
Collaborator Author

@jcohenadad, could you have a look when you find the time?

@jcohenadad
Copy link
Member

jcohenadad commented Oct 30, 2020

@PaulBautin i'm looking into that now

Yes, it was tested on a 2 subjects that caused issues in precedent runs.

can you pls specify the 2 subjects you are talking about? i'm trying to reproduce

EDIT 2020-10-30 16:59:15: Nevermind, I found the problematic subject and confirm that your new implementation solves that problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-introduce padding in transformation
2 participants