Add mirroring test-time augmentation #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valosekj
reviewed
Jan 10, 2024
valosekj
approved these changes
Jan 10, 2024
naga-karthik
commented
Jan 10, 2024
Co-authored-by: Jan Valosek <[email protected]>
| sw_batch_size=4, predictor=net, overlap=0.5, progress=False)[0], dims=[axis] | ||
| ) | ||
| # average the prediction | ||
| batch["pred"] /= 3 |
There was a problem hiding this comment.
Just wondering if averaging should be done after clamping ?
Because averaging is done before clamping, if a voxel is seen only once, its value will be 0.33 and therefore will be removed afterward at clamping (done at 0.5).
There was a problem hiding this comment.
oh man, this is an excellent catch! thanks for pointing this much important thing out! I'm going to fix it in the next commit!
There was a problem hiding this comment.
Fixed in commit 4beb690
|
@plbenveniste do you think it's good to merge after the update of moving up |
|
Looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR that updates the inference script by adding mirroring test-time augmentation. Mirroing is also done in nnunet inference and @plbenveniste also noticed improved predictions for canproco SC seg preds.